Merge Raw vis into Scalar vis #1770
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
axelboc
commented
Mar 14, 2025
|
|
||
| {isImage ? ( | ||
| <RawImageVis | ||
| <BinaryImageVis |
There was a problem hiding this comment.
I renamed this visualization component, since the term "Raw" no longer makes much sense.
Comment on lines
+49
to
+55
| return (val: unknown) => { | ||
| if (isTypedArray(val)) { | ||
| return `${val.constructor.name} [ ${val.toString()} ]`; | ||
| } | ||
|
|
||
| return JSON.stringify(val, null, 2); | ||
| }; |
There was a problem hiding this comment.
This takes care of formatting non-printable scalar values. This code was previously in RawVis.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As discussed, we end up with two fallback visualizations: one for scalar datasets and one for array datasets. If any other visualization is supported (e.g. Compound for printable scalar compound datasets), then Scalar vis is not shown.
I'm planning to clean-up the mock file and the tests a fair bit but didn't want to clutter this PR, which is already confusing because of all the files that are moved and renamed.
Note that the Scalar vis now has the ex-
RawToolbar, now calledScalarToolbar, with the "Fit image" control and the ability to export to JSON.