silx.io: Fixed test warnings with Python3.14 #4458
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
t20100
commented
Jan 9, 2026
Comment on lines
+43
to
+48
| with h5py.File(tmp_path / "nxdata_0D_scalar.h5", "w") as h5f: | ||
| group = h5f.create_group("0D_scalar") | ||
| group.attrs["NX_class"] = "NXdata" | ||
| group.attrs["signal"] = "scalar" | ||
| group.create_dataset("scalar", data=10) | ||
| group.create_dataset("scalar_errors", data=0.1) |
Member
Author
There was a problem hiding this comment.
I splitted the previous hdf5 test file generation into each test where it is actually used and also splitted test functions to have one test for each nxdata group.
| g1d2.attrs["signal"] = "counts" | ||
| g1d2.attrs["axes"] = numpy.array( | ||
| [ | ||
| class TestNXdata: |
Member
Author
There was a problem hiding this comment.
Kept the class to keep the test structure
| group.create_dataset("scalar", data=10) | ||
| group.create_dataset("scalar_errors", data=0.1) | ||
|
|
||
| assert nxdata.is_valid_nxdata(group) |
Member
Author
There was a problem hiding this comment.
testValidity is removed and is_valid_nxdata is added to each test
loichuder
approved these changes
Jan 9, 2026
Member
loichuder
left a comment
loichuder
left a comment
There was a problem hiding this comment.
Did not look into details but looks much better with the specific creation for each test
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
<Module or Topic>: <Action> <Summary>(see contributing guidelines)This PR rewrites
unitesttests with pytest to remove a miss-usage oftempfileleading to warnings with Python 3.14.closes #4456