silx.gui.data.NumpyAxesSelector: Fix alignment of axis labels #4459
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
loichuder
force-pushed
the
fix-numpy-axes-selector-aligment
branch
from
e449716 to
fc09851
Compare
loichuder
commented
Jan 13, 2026
| else: | ||
| axisLabel = f"{label} (Dim{number})" | ||
|
|
||
| self.__label = qt.QLabel(axisLabel, parent=self) |
Member
Author
There was a problem hiding this comment.
Making _label, _axes and _slider available outside of _Axis.
| self.removeWidget(axis._axes) | ||
| axis._axes.deleteLater() | ||
| self.removeWidget(axis._slider) | ||
| axis._slider.deleteLater() |
Member
Author
There was a problem hiding this comment.
deleteLater seem to be needed for every individual component. I had some weird stuff with duplicate widgets without this.
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
<Module or Topic>: <Action> <Summary>(see contributing guidelines)For #4428
I didn't see a way of doing this without a
GridLayout. Unfortunately, this means breaking the encapsulation of_Axissince the elements of_Axis(slider, label, and combobox) need to be added individually to the layout.Not very happy about this, tell me what you think.