Reduce allocation in the Trace scheduler #58
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Unbox `MVar`s and `IVar`s all over the place. * Restructure `IVarContents` to avoid extra allocation. * Reduce the use of `atomicModifyIORef` somewhat.
simonmar
reviewed
Jul 10, 2018
Owner
simonmar
left a comment
simonmar
left a comment
There was a problem hiding this comment.
I'm hesitant about just merging this without any benchmarks to demonstrate the improvement. I think the code has been quite heavily tuned already, so I'd be mildly surprised if unboxing the IVars was overlooked - perhaps they end up being reboxed again?
Contributor
Author
|
I don't think they do. Do you think you could spare a few cycles to run benchmarks? I still lack the capacity. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Unbox
MVars andIVars all over the place.Restructure
IVarContentsto avoid extra allocation.Reduce the use of
atomicModifyIORefsomewhat.