Skip to content

Make the Direct module expose less #64

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Make the Direct module expose less #64

wants to merge 1 commit into from

Conversation

@treeowl
Copy link
Contributor

@treeowl treeowl commented Jul 18, 2018 •
edited
Loading

  • Don't expose schedules (or the related MonadReader instance)
    from .Direct.

  • Don't expose IVar implementation details from there either.

  • Eliminate the orphan Show instances from there.

Fixes #62

@treeowl
Make the Direct module expose less
6ddc467 
* Don't expose schedules (or the related `MonadReader` instance)
  from `.Direct`.

* Don't expose `IVar` implementation details from there either.

* Eliminate the orphan `Show` instances from there.
@treeowl
Copy link
Contributor Author

treeowl commented Jul 19, 2018

We probably want to expose Par and IVar details from an internal module.

@simonmar
Copy link
Owner

simonmar commented Sep 17, 2018

I'd like to accept this PR but a few things remain:

  • expose representations from an internal module
  • fix the conflicts
  • we should really set up Travis so I can accept PRs without having to test them locally first

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@treeowl @simonmar