Skip to content

update flacarray version #1353

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
guanyilun merged 1 commit into from
Aug 26, 2025
Merged

update flacarray version #1353

guanyilun merged 1 commit into from
Aug 26, 2025

Conversation

@guanyilun
Copy link
Contributor

@guanyilun guanyilun commented Aug 26, 2025 •
edited
Loading

@guanyilun guanyilun requested a review from mmccrackan August 26, 2025 14:58
mmccrackan
mmccrackan approved these changes Aug 26, 2025
View reviewed changes
Copy link
Contributor

@mmccrackan mmccrackan left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested in preprocessing and I no longer see the extra FFT output log messages. Might want to get input from @ykyohei and @tskisner who I think are the ones who use this to make sure version change won't break anything else.

ykyohei
ykyohei approved these changes Aug 26, 2025
View reviewed changes
Copy link
Contributor

@ykyohei ykyohei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is fine. Thanks for confirming.

@guanyilun guanyilun requested a review from tskisner August 26, 2025 15:30
tskisner
tskisner approved these changes Aug 26, 2025
View reviewed changes
Copy link
Member

@tskisner tskisner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yep the upstream update just had this one simple fix.

@guanyilun guanyilun merged commit 6b35e66 into master Aug 26, 2025
5 checks passed
@guanyilun guanyilun deleted the update-flacarray branch August 26, 2025 16:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@tskisner tskisner tskisner approved these changes

@mmccrackan mmccrackan mmccrackan approved these changes

@ykyohei ykyohei ykyohei approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@guanyilun @tskisner @mmccrackan @ykyohei