Open
Conversation
tristpinsm
requested changes
Jan 29, 2026
Contributor
tristpinsm
left a comment
tristpinsm
left a comment
There was a problem hiding this comment.
Should we expect that valid_data not being present is possible in the pipeline? Or would its absence indicate something has gone wrong? I'm wondering because that would determine whether it is best to raise an exception (the latter) or populate an empty result / fallback on another dataset (former).
Apart from that, my only request is that the new behaviour be explained in the docstring.
| The threshold for the fraction of valid samples above which a detector is | ||
| deemed good (default 0.75) | ||
| process_name : str | ||
| The process from which to read the valid dataset. (default 'glitches') |
Contributor
There was a problem hiding this comment.
The behaviour should be explained in the docs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Preprocessing added a
valid_dataAxisManagerto thepreprocessAxisManagerin #1371 that keeps track of the final number of detectors at the end of preprocessing. This adds the option to use that instead of passing a field name. The field's validRangesMatrixand thevalid_data.valid_dataRangesMatrixmay vary since the former is added before the final process'sselectfunction (not a concern for the current lite metrics, since the final noise processes do not runselect).