Enable loading price data over plain HTTP#44
Open
reddog wants to merge 1 commit intosimonw:mainfrom
Open
Conversation
…hrome over plain HTTP (for local development / usage purposes).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Switch method to load price data.
New solution pattern:
index.htmlto load current prices switched fromfetchto defining ascripttag.scripttag is added after the DOM has loaded to ensure JS inindex.htmlis available.index.htmlis called by the current prices JS script (current-v1.js)index.htmlProcessing follows this flow:
index.htmlis loaded in the browserindex.html, we wait until the DOM has loaded and then we:scripttag to loadcurrent-v1.jscurrent-v1.jswill be loadedcurrent-v1.jsis enclosed in a IIFE to protect itself and other scriptsindex.htmlis called to parse model prices - this continues the usual process flow.Previous method uses JS
fetch. This fails in Chrome when loading the file locally with a CORS Schema error.Anticipated benefit is that users can run the web page locally for development / usage purposes.
Previously Chrome error was;