Handle None in tool/function arguments. #1170
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @simonw. The |
The normal OpenAI API returns an empty string when there are no function
arguments. The GitHub Copilot wrapper around the OpenAI API seems to
return None instead of an empty string when there are no arguments.
Treat None as an empty string. If we still have an empty string at the
point that we parse the JSON for the arguments, then use "{}" instead so
that we get the expected empty map.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The normal OpenAI API returns an empty string when there are no function arguments. The GitHub Copilot wrapper around the OpenAI API seems to return None instead of an empty string when there are no arguments.
Treat None as an empty string. If we still have an empty string at the point that we parse the JSON for the arguments, then use "{}" instead so that we get the expected empty map.
This patch is for supporting the full function of this PR: jmdaly/llm-github-copilot#18 But either can be merged in any order, the two together enable tool calling of anthropic models via github copilot plugin (openai tool calling via github copilot's API works without this patch).