SSP-2066_add_routes_and_controllers

[ioigoume]

Closes #26

[codecov]

Codecov Report

Attention: Patch coverage is 88.88889% with 60 lines in your changes missing coverage. Please review.

Project coverage is 67.36%. Comparing base (2b946a9) to head (0961460).
Report is 83 commits behind head on master.

Additional details and impacted files

@@              Coverage Diff              @@
##             master      #45       +/-   ##
=============================================
+ Coverage     41.43%   67.36%   +25.92%     
- Complexity      204      342      +138     
=============================================
  Files            14       26       +12     
  Lines           654     1238      +584     
=============================================
+ Hits            271      834      +563     
- Misses          383      404       +21     

[pradtke]

Thanks for all the improvements @ioigoume . I think the last issue I ran into was with debugMode not working (and when I made some minor changes to fix it, then how the content is displayed isn't quite right)

[tvdijen]

I have one more remark on the public-folder.. I see we're copying in jQuery and highlight.js.

• We have https://github.com/simplesamlphp/simplesamlphp-assets-jquery available. It can be installed as a composer-dependency and it is automatically updated when a new jQuery release is released. Files go to public/assets/jquery/ in the SimpleSAMLphp base directory.

• highlight.js is already available in SimpleSAMLphp, so we shouldn't be needing that in this module.

Maybe we can reduce complexity of this module by re-using what's already available?

[ioigoume]

I have one more remark on the public-folder.. I see we're copying in jQuery and highlight.js.

* We have `https://github.com/simplesamlphp/simplesamlphp-assets-jquery` available. It can be installed as a composer-dependency and it is automatically updated when a new jQuery release is released. Files go to `public/assets/jquery/` _in the SimpleSAMLphp base directory_.

* highlight.js is already available in SimpleSAMLphp, so we shouldn't be needing that in this module.

Maybe we can reduce complexity of this module by re-using what's already available?

@tvdijen thank you for the hints. I refactored the code according to your recommendations.

[tvdijen]

@tvdijen thank you for the hints. I refactored the code according to your recommendations.

You have to add simplesamlphp/simplesamlphp-assets-jquery to the composer.json to be able to use it.

[ioigoume]

@tvdijen thank you for the hints. I refactored the code according to your recommendations.

You have to add simplesamlphp/simplesamlphp-assets-jquery to the composer.json to be able to use it.

@tvdijen after the latest updates it is not required anymore.

[pradtke]

I've tested debug mode and it both works and looks much nicer than the old version.

Thanks for all your work improving this module. I think it is ready to merge and for others to be able to test. I assume a v7.0.0-rc3 release/tag after the merge is appropriate?

[tvdijen]

tagged v7.0.0-rc3