fix: from-folder discarding files as "extension not included"
#1130
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
hey so we need to wait untill merged and new version availale to see it working? (sorry I don't get Git yet) |
niieani
changed the title
from-folder defaults to blank in immich-go developfrom-folder discarding files as "extension not included"
|
Related to #1122 as well |
niieani
force-pushed
the
fix/upload-default-scan
branch
2 times, most recently
from
4090952 to
76f0f5c
Compare
|
I am not that technical a person, I've just been uploading today into a new immich installation and getting a lot of discrded. So I read your explanation above, but I'm not understanding if that actually discarded all these pictures, or it just said it did. Do I have to re-do all my uploadsd? And can I, will there be hash issues? Using immich-go version 0.28.0.
|
Develop branch broke the default from-folder scan by always pre-populating InclusionFlags.IncludedExtensions with sidecar-only values. That meant Include() stopped returning true for MP4/ARW files whenever --include-type was left unset, so our fixture uploads discarded every clip. Only expand the include list when the user explicitly asks for IMAGE/VIDEO filtering, which matches the older Cobra PreRun hook. Added regression tests to prove the default path remains empty while VIDEO mode still seeds video+sidecar extensions.
niieani
force-pushed
the
fix/upload-default-scan
branch
from
76f0f5c to
71480e4
Compare
Contributor
Author
|
@simulot rebased on develop |
Owner
|
Hi, have you checked if the problem isn't already solved on the develop branch? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1121
Summary
immich-go upload from-folderruns were discarding files as "extension not included" becauseSetIncludeTypeExtensions()always seeded the include list with only sidecar extensions. That regression arrived when the CobraPreRunguard was removed in a recent refactor.ImportFolderCmd, so browsing never saw any assets and logging nil-panicked.Key Changes
SetIncludeTypeExtensions()work unless--include-typeis set.internal/cliFlags/extensionList_test.gofor both default andVIDEOmodes.fshelper.ParsePathresult inImportFolderCmd.fsyssbefore spinning workers.fileevent.Recorderwhenapp.Jnl()is nil, preventing nil-pointer panics while logging.Verification
go test ./...go run . upload from-folder test_folder --no-ui ...now correctly discovers files and no longer drops it as "extension not included" and uploads the files