test: add IsEqual test cases for number vs bigint#1466
Open
DakshSinghDhami wants to merge 4 commits into
Open
Conversation
added 2 commits
June 28, 2026 21:49
Add test cases verifying that number and bigint types are correctly identified as distinct types by IsEqual.
Add tests covering: - Same bigint literals (should be equal) - Different bigint values (should be equal - same type) - Number vs bigint literals (should not be equal) - Number vs bigint types (should not be equal)
Emiyaaaaa
approved these changes
Jul 9, 2026
Owner
|
#1442 is an open design discussion about whether to add a loose/numeric-equality type ( |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Issue #1442 raised a question about whether
IsEqual<100, 100n>should betrueorfalse. After investigation, the current behavior (false) is correct becausenumberandbigintare distinct types in TypeScript and use strict equality (===) in JavaScript.Changes
IsEqualcorrectly distinguishes betweennumberandbiginttypesCloses #1442