Skip to content

Comments

TDL-16446: Fix zombie process and missing data#78

Open
savan-chovatiya wants to merge 6 commits intomasterfrom
TDL-16446-fix-zombie-process-and-missing-events
Open

TDL-16446: Fix zombie process and missing data#78
savan-chovatiya wants to merge 6 commits intomasterfrom
TDL-16446-fix-zombie-process-and-missing-events

Conversation

@savan-chovatiya
Copy link
Contributor

@savan-chovatiya savan-chovatiya commented Nov 23, 2021

Description of change

TDL-16446: Fix zombie process and missing data

  • Changed bookmark logic for child streams.

NOTE: This will resolve data missing of interrupted sync as per approach mentioned in slack thread but not zombie process as the tap is making visitor_history requests for every visitor and for each day.

Manual QA steps

Risks

Rollback steps

  • revert this branch

@savan-chovatiya savan-chovatiya marked this pull request as draft November 23, 2021 10:53
@dbshah1212 dbshah1212 marked this pull request as ready for review November 23, 2021 14:29
Copy link
Contributor

@dmosorast dmosorast left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Hopefully this will improve the quality of data for those with large data sets.

@savan-chovatiya savan-chovatiya changed the title TDL-16646: Fix zombie process and missing data TDL-16446: Fix zombie process and missing data Nov 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants