Skip to content

fix: Resolve client disconnect when opening containers in Spectator mode due to null packet buffer #2449

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
XUANHLGG wants to merge 1 commit into
base: mc1.21.1
Choose a base branch
from
Open

fix: Resolve client disconnect when opening containers in Spectator mode due to null packet buffer #2449

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions ...in/java/moze_intel/projecte/gameObjs/registration/impl/ContainerTypeDeferredRegister.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,6 +41,14 @@ public <CONTAINER extends AbstractContainerMenu> ContainerTypeRegistryObject<CON

private static <BE extends BlockEntity> BE getBlockEntityFromBuf(FriendlyByteBuf buf, Class<BE> type) {
if (buf == null) {
net.minecraft.world.phys.HitResult hit = Minecraft.getInstance().hitResult;
if (hit instanceof net.minecraft.world.phys.BlockHitResult blockHit) {
BlockPos pos = blockHit.getBlockPos();
BE blockEntity = WorldHelper.getBlockEntity(type, Minecraft.getInstance().level, pos);
if (blockEntity != null) {
return blockEntity;
}
}
throw new IllegalArgumentException("Null packet buffer");
} else if (FMLEnvironment.dist.isDedicatedServer()) {
throw new UnsupportedOperationException("This method is only supported on the client.");
Expand Down