Layered reservoir - #33
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request introduces a new utility for constructing layered reservoir domains and refactors several case setup functions to use this utility, improving consistency and flexibility in handling layer properties. It also adds comprehensive tests for the new utility and tightens input validation for meshing. Minor improvements and citation updates are also included.
Layered domain utility and refactoring:
layered_reservoir_domainfunction insrc/cases/utils/layered_domain.jlto centralize mesh creation and layer property mapping for reservoir domains, supporting flexible property input and error handling.ags,btes,geothermal_doublet) insrc/cases/ags.jl,src/cases/btes.jl, andsrc/cases/doublet.jlto uselayered_reservoir_domain, simplifying property handling and mesh generation. [1] [2] [3]src/cases/cases.jlto load the new utility module.Testing and validation improvements:
test/layered_domain.jlwith extensive tests forlayered_reservoir_domain, covering correct property mapping, return types, and error handling for invalid inputs.extruded_mesh(src/meshing/extruded.jl), enforcing that depths are sorted and that layer thicknesses and mesh parameters are consistent. [1] [2]Minor improvements and fixes:
start_yearexplicitly for reproducibility intest/cases.jl. [1] [2]Fimbul.jlinCITATION.cff.Case-specific adjustments:
geothermal_doubletMiscellaneous:
test/runtests.jl.