Fix ignoreMissingOldVersion and NewVersion check#175
Merged
siom79 merged 1 commit intosiom79:masterfrom Sep 13, 2017
Merged
Conversation
UnasZole
force-pushed
the
fixIgnoreMissingCheck
branch
from
e021f57 to
68a59e0
Compare
UnasZole
force-pushed
the
fixIgnoreMissingCheck
branch
from
68a59e0 to
ed1c9b3
Compare
Contributor
Author
|
I also adapted the JUnits to match my understanding of how these options should have worked. Please review, and tell me what is the correct behaviour supposed to be ! Also, if the fix is accepted, how long do you think it will take to get a new release with the fix (0.10.1 I guess ?) on Maven Central ? I'd need this to work as soon as possible ! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix for issue #174