Added more unit tests for japicmp-maven-plugin#493
Merged
siom79 merged 7 commits intosiom79:masterfrom Feb 9, 2026
Merged
Conversation
…e properties in the path correctly.
…support unit tests.
…d HelpMojo class.
Contributor
Author
|
I added a unit test that goes against the Apache |
siom79
reviewed
Jan 29, 2026
Owner
siom79
left a comment
siom79
left a comment
There was a problem hiding this comment.
Thanks for your work. I have two minor comments.
| + Joiner.on(',').join( | ||
| JApiSemanticVersionLevel.values())); | ||
| } | ||
| // This is dead code. foundSemanticVersionLevel is initialized above, and the for-loop |
Owner
There was a problem hiding this comment.
Yes, this seems to be dead code. Can we remove it completely instead of commenting it out?
| } else { | ||
| throw new MojoFailureException("Could not resolve property '" + property + "'."); | ||
| } | ||
| // Substitute any properties in the path with their values |
Owner
There was a problem hiding this comment.
Is it possible to extract this into a method with the name substituteProperties() or similiar?
Contributor
Author
|
Done and Done. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is almost entirely new unit tests for the plugin - up to almost 85% coverage of instructions. Two deliverable classes were changed:
ConfigParameters: I added setters for a couple of properties inOverrideCompatibilityChangeParameter.JApiCmpProcessor: I commented out some dead code related to semantic version levels (please confirm my logic). I also refactoredresolveDependencyToFileto properly substitute property values in thesystemPathdefined in theDependency.I'm still working on a unit test that would have caught the problem found by the Apache
httpcomponentsteam.