cleanup(env): drop dead SIPHER_OPENROUTER_API_KEY#306
Merged
Conversation
pi-ai reads only the canonical OPENROUTER_API_KEY (see @mariozechner/pi-ai/dist/env-api-keys.js:93). The SIPHER_OPENROUTER_API_KEY variable was unused by code, but its presence in .env.example and docs/deployment.md created ambiguity. In frontier_sip_17 this caused a silent prod chat outage: the valid key was saved under the sipher-prefixed name, the invalid (old) key under OPENROUTER_API_KEY, and pi-ai used the invalid one — emitting empty content with no error log. Removes the dead reference from .env.example and docs/deployment.md. Adds an inline comment in .env.example to discourage reintroducing the prefixed form. docker-compose.yml in the repo never declared it, so no change there (the VPS-side compose still has it and is addressed separately in #294). Closes #295.
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Closes #295. pi-ai reads only the canonical
OPENROUTER_API_KEY(see@mariozechner/pi-ai/dist/env-api-keys.js:93).SIPHER_OPENROUTER_API_KEYwas unused but lingered in.env.exampleanddocs/deployment.md, creating ambiguity. Infrontier_sip_17this caused a silent prod chat outage when the valid key was stored under the sipher-prefixed name and the invalid one underOPENROUTER_API_KEY— pi-ai used the invalid key and emitted empty content with no error log.Changes
.env.example: dropsSIPHER_OPENROUTER_API_KEY=line; adds an inline "DO NOT reintroduce" comment so a future copy-paste doesn't regress.docs/deployment.md: collapses the two rows into a single canonicalOPENROUTER_API_KEYrow.docker-compose.yml: unchanged — repo never declared the prefixed form (VPS-side drift addressed in chore(deploy): reconcile VPS docker-compose.yml with repo — divergent SIPHER_MODEL default, other drift #294).Test plan
grep -rn SIPHER_OPENROUTER_API_KEYacross the repo: only the new "DO NOT reintroduce" comment in.env.exampleremains.pnpm typecheckclean across root + sdk + app + agent.Follow-ups
The VPS
~/sipher/.envstill has the prefixed variable. RECTOR can remove it during the next deploy. The VPSdocker-compose.ymldrift is addressed separately by #294.