Conversation
psvenk
reviewed
Jan 26, 2026
Member
psvenk
left a comment
psvenk
left a comment
There was a problem hiding this comment.
I would also set the base and basename properties, à la 26b87ec, and add a comment saying that these should be changed in the event of a non-root deployment. It looks like the Vite base can be set to "./" or "" to make all URLs relative, so the React Router basename should be the only thing that needs to change when building for deployment to a subdirectory.
psvenk
approved these changes
Jan 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We fetch things from
/a lot. When setting up the gh-pages branch for #284 testing, this was complicated since we were deploying from a subdirectory. Adding this now will make setting up a dev endpoint in the (possible) future easier.