IO-layer portability guard, Add coverage for the DuckDB-native scan IO path#938
Merged
mbrobbel merged 1 commit intoJun 22, 2026
Merged
Conversation
The DuckDB-native GPU scan resolves its file IO through the scan manager's create_datasource() seam and reads exclusively via host_read_ranges_async_io, both of which the S3 backend already implements -- but no test exercised that combination. Add integration coverage that uploads a real multi-block .duckdb file to MinIO and verifies the S3 ioctx serves the native decoder's exact range shapes (header ranges, all-block payload batch, whole-file, and many small interleaved ranges) byte-identically against local reads, and that a duckdb_native_gpu_ingestible built with an s3:// db_path carries an S3-backed io_ctx/io_object while a backend-less manager yields null handles. Tagged [.][s3][integration][duckdbnative] so make s3-test runs them under the self-managed MinIO harness while the default Catch2 run stays offline.
ran-yuan-rui
changed the title
mbrobbel
approved these changes
Jun 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The DuckDB-native GPU scan resolves its file IO through the scan manager's create_datasource() seam and reads exclusively via host_read_ranges_async_io, both of which the S3 backend already implements -- but no test exercised that combination. Add integration coverage that uploads a real multi-block .duckdb file to MinIO and verifies the S3 ioctx serves the native decoder's exact range shapes (header ranges, all-block payload batch, whole-file, and many small interleaved ranges) byte-identically against local reads, and that a duckdb_native_gpu_ingestible built with an s3:// db_path carries an S3-backed io_ctx/io_object while a backend-less manager yields null handles.
Tagged [.][s3][integration][duckdbnative] so make s3-test runs them under the self-managed MinIO harness while the default Catch2 run stays offline.