feat(starrocks): bring up a Sirius engine context in the CN#960
Merged
Conversation
mbrobbel
force-pushed
the
starrocks-context
branch
from
June 16, 2026 18:36
94a57eb to
a5ce2aa
Compare
Wire the embedded Sirius engine into the StarRocks compute node lifecycle: create an engine context at startup, configure it (optional YAML via a new FFI entry point, else built-in defaults), and tear it down on shutdown. - FFI: add a config-file Context constructor and make_context_from_config to the public surface; make the cxx bindings fallible so bad config / GPU bring-up failures surface as errors instead of aborting. - sirius crate: SiriusContext::new now returns Result, plus a new from_config_file constructor. - CN: add a default-on `sirius-engine` Cargo feature and a --sirius-config flag; bring the context up before serving (fail-fast) and drop it after the thrift servers stop. Without the feature the flag is ignored with a warning. - pixi: engine-build builds libsirius from source via the repo-root build; an `engine` feature (deps copied from the root pixi.toml) gives the default env the toolchain/libs to build and run the engine-linked CN. CI keeps the pure-Rust path via --no-default-features. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
mbrobbel
force-pushed
the
starrocks-context
branch
from
June 16, 2026 18:55
a5ce2aa to
3166528
Compare
mbrobbel
marked this pull request as ready for review
June 16, 2026 19:24
bwyogatama
approved these changes
Jun 23, 2026
mbrobbel
enabled auto-merge
June 23, 2026 15:29
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Wire the embedded Sirius engine into the StarRocks compute node lifecycle: create an engine context at startup, configure it (optional YAML via a new FFI entry point, else built-in defaults), and tear it down on shutdown.
sirius-engineCargo feature and a --sirius-config flag; bring the context up before serving (fail-fast) and drop it after the thrift servers stop. Without the feature the flag is ignored with a warning.enginefeature (deps copied from the root pixi.toml) gives the default env the toolchain/libs to build and run the engine-linked CN. CI keeps the pure-Rust path via --no-default-features.