Skip to content

fix: silence build warnings in hash join and pipeline task #971

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
mbrobbel wants to merge 1 commit into
base: dev
Choose a base branch
from
Open

fix: silence build warnings in hash join and pipeline task #971

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/include/data/convertible_gpu_pipeline_task.hpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -84,7 +84,7 @@ class convertible_gpu_pipeline_task : public convertible_data {
*/
~convertible_gpu_pipeline_task() override
{
if (_task) { _queue.push(std::move(_task)); }
if (_task) { (void)_queue.push(std::move(_task)); }
}

/**
Expand Down
4 changes: 2 additions & 2 deletions src/op/sirius_physical_hash_join.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -68,7 +68,7 @@ static bool is_equality(sirius::comparison_type c)
static cudf::filtered_join make_right_filtered_join(cudf::table_view const& right_keys,
rmm::cuda_stream_view stream)
{
#if CUDF_VERSION_MAJOR > 26 || (CUDF_VERSION_MAJOR == 26 && CUDF_VERSION_MINOR >= 8)
#if CUDF_VERSION_MAJOR > 26 || (CUDF_VERSION_MAJOR == 26 && CUDF_VERSION_MINOR >= 6)
return cudf::filtered_join(right_keys, cudf::null_equality::UNEQUAL, stream);
#else
return cudf::filtered_join(
Expand All @@ -81,7 +81,7 @@ static cudf::filtered_join make_right_filtered_join(cudf::table_view const& righ
static std::unique_ptr<cudf::filtered_join> make_right_filtered_join_ptr(
cudf::table_view const& right_keys, rmm::cuda_stream_view stream)
{
#if CUDF_VERSION_MAJOR > 26 || (CUDF_VERSION_MAJOR == 26 && CUDF_VERSION_MINOR >= 8)
#if CUDF_VERSION_MAJOR > 26 || (CUDF_VERSION_MAJOR == 26 && CUDF_VERSION_MINOR >= 6)
return std::make_unique<cudf::filtered_join>(right_keys, cudf::null_equality::UNEQUAL, stream);
#else
return std::make_unique<cudf::filtered_join>(
Expand Down
Loading