ci: enable linting test files #1477
Open
+27
−19
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This suppresses the following staticcheck warnings in tests:
hooks/test/test_test.go:76:2: SA4006: this value of assert is never used (staticcheck)
assert := assert.New(t)
^
hooks/test/test_test.go:78:2: SA4006: this value of hook is never used (staticcheck)
logger, hook := NewNullLogger()
^
...and fixes the following staticcheck and unparam warnings in tests:
json_formatter_test.go:232:5: QF1001: could apply De Morgan's law (staticcheck)
if !(strings.Contains(s, "message") && strings.Contains(s, "oh hai")) {
^
json_formatter_test.go:369:5: QF1001: could apply De Morgan's law (staticcheck)
if !(strings.Contains(s, "u0026") && strings.Contains(s, "u003e") && strings.Contains(s, "u003c")) {
^
hooks/test/test_test.go:96:11: TestNewLocal$1 - i is unused (unparam)
go func(i int) {
^
Signed-off-by: Kir Kolyshkin <[email protected]>
Signed-off-by: Kir Kolyshkin <[email protected]>
Mostly generated with golangci-lint run --fix ./... Signed-off-by: Kir Kolyshkin <[email protected]>
thaJeztah
reviewed
Jan 27, 2026
Collaborator
thaJeztah
left a comment
thaJeztah
left a comment
There was a problem hiding this comment.
overall looks good; left two suggestions; let me know what you think
Comment on lines
-369
to
371
| if !(strings.Contains(s, "u0026") && strings.Contains(s, "u003e") && strings.Contains(s, "u003c")) { | ||
| if !strings.Contains(s, "u0026") || !strings.Contains(s, "u003e") || !strings.Contains(s, "u003c") { | ||
| t.Error("Message should be HTML escaped", s) | ||
| } |
Collaborator
There was a problem hiding this comment.
Looks like we should have a predictable output here, so we can just match the escaped sequence for & < >;
Suggested change
| if !(strings.Contains(s, "u0026") && strings.Contains(s, "u003e") && strings.Contains(s, "u003c")) { | |
| if !strings.Contains(s, "u0026") || !strings.Contains(s, "u003e") || !strings.Contains(s, "u003c") { | |
| t.Error("Message should be HTML escaped", s) | |
| } | |
| if !strings.Contains(s, `\u0026 \u003c \u003e`) { | |
| t.Error("Message should be HTML escaped", s) | |
| } |
Comment on lines
-232
to
233
| if !(strings.Contains(s, "message") && strings.Contains(s, "oh hai")) { | ||
| if !strings.Contains(s, "message") || !strings.Contains(s, "oh hai") { | ||
| t.Fatal("Expected JSON to format message key") |
Collaborator
There was a problem hiding this comment.
Same for this one; I expect the JSON format to be stable enough;
Suggested change
| if !(strings.Contains(s, "message") && strings.Contains(s, "oh hai")) { | |
| if !strings.Contains(s, "message") || !strings.Contains(s, "oh hai") { | |
| t.Fatal("Expected JSON to format message key") | |
| if !strings.Contains(s, `"message":"oh hai"`) { | |
| t.Fatal("Expected JSON to format message key", s) | |
| } |
FWIW; output here looks to be {"level":"panic","message":"oh hai","time":"0001-01-01T00:00:00Z"} so possibly we could even do a straight compare for the whole message, but either way is probably fine.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a followup to #1476, inspired by #1476 (comment).
See individual commits for details.