Skip to content

TASK: Detect non scaleable image types from missing dimensions to allow cooperation with kaleidoscope.svg without declaring a dependency #21

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mficzel merged 3 commits into from
Jan 7, 2026
Merged

TASK: Detect non scaleable image types from missing dimensions to allow cooperation with kaleidoscope.svg without declaring a dependency #21

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
5c77000
FEATURE: Use SvgImageSource for SvgImages that have width and height
mficzel Oct 1, 2025
5170d2c
FEATURE: Remove SVG image source and let asset image source decide we…
mficzel Oct 6, 2025
f0fabc2
TASK: Detect non scaleable image types from missing dimensions to all…
mficzel Jan 7, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 2 additions & 8 deletions Classes/Factory/ImageSourceFactory.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,7 @@
use Neos\Flow\ResourceManagement\ResourceManager;
use Sitegeist\Kaleidoscope\Domain\AssetImageSource;
use Sitegeist\Kaleidoscope\Domain\ImageSourceInterface;
use Sitegeist\Kaleidoscope\Domain\SvgAssetImageSource;
use Sitegeist\Kaleidoscope\Domain\UriImageSource;
use Sitegeist\Kaleidoscope\ValueObjects\ImageSourceProxy;
use Sitegeist\Kaleidoscope\ValueObjects\ImageSourceProxyCollection;
Expand All @@ -20,13 +21,6 @@ class ImageSourceFactory
#[Flow\Inject]
protected ResourceManager $resourceManager;

/**
* @var string[]
*/
protected array $nonScalableMediaTypes = [
'image/svg+xml',
];

public function tryCreateFromProxy(ImageSourceProxy $imageSourceProxy): ?ImageSourceInterface
{
$image = $this->imageFactory->tryCreateFromProxy($imageSourceProxy->asset);
Expand All @@ -35,7 +29,7 @@ public function tryCreateFromProxy(ImageSourceProxy $imageSourceProxy): ?ImageSo
return null;
}

if (in_array($image->getResource()->getMediaType(), $this->nonScalableMediaTypes, true)) {
if (!$image->getWidth() || !$image->getHeight()) {
$uri = $this->resourceManager->getPublicPersistentResourceUri($image->getResource());
if (is_string($uri)) {
return new UriImageSource(
Expand Down