Conversation
…itegeist.Kaleidoscope.ValueObjects.Migrations package
mficzel
changed the title
Sitegeist.Kaleidoscope.ValueObjects.Migrations package
mficzel
force-pushed
the
bugfix/preventPhpErrorsInNeos9
branch
from
e261b4e to
2e12dee
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The problems occurred because the node-migrations for Neos 8 use a base class that is no longer present in Neos9 and thus PHP complains hard about non existing classes.
As a solution we extracted the Neos 8 migrations into the saperate package Sitegeist.Kaleidoscope.ValueObjects.Migrations that supports only Neos 8 and remove those here. The classes and namespaces are exactly as before so you only have to require the package.
!!! I am aware that this is technically breaking but will still release this as a feature release as it makes the package usable in Neos 9. Since we continue to work on The editors here it would be too much hassle to maintain multiple versions of this pretty new package already !!!