Skip to content

feat: option to (partly) prevent syncing and translation#32

Open
hphoeksma wants to merge 2 commits intositegeist:2.0from
hphoeksma:feat/prevent-translations
Open

feat: option to (partly) prevent syncing and translation#32
hphoeksma wants to merge 2 commits intositegeist:2.0from
hphoeksma:feat/prevent-translations

Conversation

@hphoeksma
Copy link
Contributor

Fixes: #31

@gradinarufelix
Copy link
Collaborator

Sorry for the long delay. I had a look at it now and I like the idea.

My only question is: do you think it is enough to just test the parent node? In my opinion, it has to be recursive. In other words, once I set this option on a content node, it disabled translations for all content nodes below to the n-th layer. Otherwise, you could have the following case:

  • Document Node
    • Content Collection
      • Button Group
        • Button

If you enabled preventTranslation on the collection, it would hold for the ButtonGroup but not for the Button.

Am I right here or did I misunderstand something in your code?

@gradinarufelix gradinarufelix self-requested a review January 25, 2024 16:14
@gradinarufelix gradinarufelix self-assigned this Jan 25, 2024
@hphoeksma
Copy link
Contributor Author

Hmm... the idea was that once a collection is marked as prevented, nothing in that collection is translated. But it could be I did not test / need it recursively...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

FEATURE: Prevent synchronisation & automatic translations for parts of a page

2 participants