feat: option to (partly) prevent syncing and translation#32
Open
hphoeksma wants to merge 2 commits intositegeist:2.0from
Open
feat: option to (partly) prevent syncing and translation#32hphoeksma wants to merge 2 commits intositegeist:2.0from
hphoeksma wants to merge 2 commits intositegeist:2.0from
Conversation
Collaborator
|
Sorry for the long delay. I had a look at it now and I like the idea. My only question is: do you think it is enough to just test the parent node? In my opinion, it has to be recursive. In other words, once I set this option on a content node, it disabled translations for all content nodes below to the n-th layer. Otherwise, you could have the following case:
If you enabled Am I right here or did I misunderstand something in your code? |
Contributor
Author
|
Hmm... the idea was that once a collection is marked as prevented, nothing in that collection is translated. But it could be I did not test / need it recursively... |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes: #31