Allow addSpecies() to proceed with warning when growth stops after maturity #315
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently
addSpecies()aborts if newly-added species have zero growth rates anywhere before reaching maximum size, preventing interactive parameter tuning. This should only error if species cannot reach maturity.Changes
R/steadySingleSpecies.R: Modified growth check to distinguish between pre-maturity (error) and post-maturity (warning) zero growthfirst_zero_idx < w_mat_idxfirst_zero_idx >= w_mat_idxtests/testthat/test-steadySingleSpecies.R: Added test coverage for both error and warning casesExample
Warning
Firewall rules blocked me from connecting to one or more addresses (expand for details)
I tried to connect to the following addresses, but was blocked by firewall rules:
cloud.r-project.org/usr/local/lib/R/bin/exec/R --no-save --no-restore --no-echo --no-restore -e install.packages("remotes",~+~repos="REDACTED")(dns block)If you need me to access, download, or install something from one of these locations, you can either:
Original prompt
addSpecies()only issue warning if feeding level drops below critical level #280✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.