Added chown and chmod support #25
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Added DIRECTORY_PERMISSIONS to set the chown command on the shared_directory
|
Sorry I seem to have completely missed this, I'll take a closer look soon |
|
Finally got to this. I'd like to include it but I think the new if statements should come after the SHARED_DIRECTORY_2 block and the variable names should be consistent, say DIRECTORY_UID and DIRECTORY_PERMISSIONS? Perhaps maybe a dedicated variable and logic for the GID too? Quite happy to make those changes in my own branch if you don't have the time or desire. Please let me know. |
- Updated namings of env variables - Updated docs
|
Sorry for the extreme delay :-) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello
I'm not sure whether you're interested, but I provided a few new environment parameters in order to set the shared directory to the provided owner and provided file permissions.
If any changes requested, let me know!
Best regards,
Hacor