[NEC_NT] Bug fixes #219
[NEC_NT] Bug fixes #219
Conversation
… that don't need adapters to be clicked
…able service details screen shows
…ing and formatting across screens that uses date and time
|
❌ Unit tests failed! @MichaelReyes, please review and fix the issues in the unit tests. Test results are available under the "Artifacts" section of this run in GitHub Actions. |
|
❌ Unit tests failed! @MichaelReyes, please review and fix the issues in the unit tests. Test results are available under the "Artifacts" section of this run in GitHub Actions. |
|
✅ Unit tests passed successfully! Test results are available under the "Artifacts" section of this run in GitHub Actions. Please ensure the code is reviewed before proceeding with the merge. |
|
|
||
| when { | ||
| daysDiff == 0 -> { | ||
| val timePattern = SystemTimeFormatManager.getTimeFormatPattern() |
There was a problem hiding this comment.
Can be extracted to only be calculated once.
| } | ||
| } | ||
| } catch (e: Exception) { | ||
| e.printThrowableStackTrace() |
There was a problem hiding this comment.
Can be replaced by Timber or Log
| @@ -70,5 +73,26 @@ data class GenericListItem( | |||
|
|
|||
| return emptyList() | |||
| } | |||
|
|
|||
| private fun formatTime(context: Context, timeInMillis: Long): String { | |||
There was a problem hiding this comment.
Some identical logics can be extracted.
Pull Request (PR) Checklist
Thank you for your contribution! Please confirm that you've checked all the boxes below before submitting your PR. Use
[x]to check a box, e.g.,[x], and make sure there's no space around the brackets.PR Context
Changes
Describe your changes in detail, highlighting the problem it solves or the feature it adds.
Checklist for Reviewers
Documentation and Code Quality
Testing and Reliability
Error Handling and Logging
Testing Procedure
If applicable, provide steps or commands for testing your changes. This can help reviewers and testers.
Work-in-Progress (WIP)
List any remaining work or areas that need additional focus. This section can be updated as the work progresses.
Remember to keep this template updated based on the feedback and evolving project standards.