-
Notifications
You must be signed in to change notification settings - Fork 15
docs(be): add JSDoc into NotificationService with Refactoring #3364
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…onRecord handling
|
✅ Syncing Preview App Succeeded Application: |
|
✅ Syncing Preview App Succeeded Application: |
|
✅ Syncing Preview App Succeeded Application: |
|
✅ Syncing Preview App Succeeded Application: |
|
추가적으로 기존 테스트 파일( 다만, |
RyuRaseul
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM👍
Description
NotificationService의 함수들의 역할을 명확히하기 위해 JSDoc을 추가했습니다.Additional context
추가적인 리팩토링을 진행하였습니다.
codedang/apps/backend/apps/admin/src/notification/notification.service.ts
Lines 196 to 212 in 705aa73
기존에는 위 코드와 같이 notification 엔티티를 생성한 후 notificationRecord 엔티티를 별도로 생성하도록 되어 있었습니다.
2번의 쿼리 호출이 비효율적인 것 같아 다음과 같이 1번의 쿼리 호출로 모든 엔티티가 생성되도록 변경하였습니다.
codedang/apps/backend/apps/admin/src/notification/notification.service.ts
Lines 246 to 258 in bc5d83e
Closes TAS-2446
Before submitting the PR, please make sure you do the following
fixes #123).