-
Notifications
You must be signed in to change notification settings - Fork 15
docs(be): add client user jsdoc #3374
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
✅ Syncing Preview App Succeeded Application: |
|
✅ Syncing Preview App Succeeded Application: |
RyuRaseul
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
아직 JSDoc이 작성되지 않은 API들도 귀찮으시겠지만 부탁드립니다!
| /** | ||
| * | ||
| * @param {string} email 이메일 주소 | ||
| * @return | ||
| */ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
여기가 비어있어요! 채워주시면 감사하겠습니다!
| * | ||
| * @param {string} newPassword 변경하려는 새로운 비밀번호 | ||
| * @param {Request} req | ||
| * @throws {UnprocessableDataException} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
어떤 상황에 해당 Exception이 발생하는지 적어주면 좋을 것 같습니다!
| * | ||
| * @param {string} key 사용자 식별을 위한 key값 (이메일 주소) | ||
| * @param {string} value 캐시하는 value값 (pin 번호) | ||
| * @param {number} ttl 인증이 유효한 시간 (TTL) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
TTL이 몇 분으로 설정되어있는지 추가해주세요!
지금 구조 상으로는 5분으로 되어있습니다!
| } | ||
|
|
||
| /** | ||
| * 입력된 비밀번호가 설정한 형식에 부합하는 올바른 비밀번호인지 검증합니다. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
여기도 밑에 있는 정규식을 풀어서 써주면 좋을 것 같아요!
해당 정규식은 8자 이상, 영어 소문자, 대문자, 숫자, 특수문자를 적어도 1개씩 포함하라는 의미인 것 같습니다!
| /** | ||
| * DB에 새로운 user 프로필을 생성합니다. | ||
| * | ||
| * @param createUserProfileData user 프로필 정보 | ||
| * @returns {Promise<UserProfile>} 생성된 user 프로필 객체를 반환합니다. | ||
| */ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Exception 추가
Description
client user jsdoc 추가 및 보완
Before submitting the PR, please make sure you do the following
fixes #123).