Feat: Add SPK Farms Deployment Scripts #36
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| function run() external returns (bool) { | ||
| Reader deps = new Reader(ScriptTools.loadDependencies()); | ||
|
|
||
| address admin = deps.readAddress(".admin"); |
Member
There was a problem hiding this comment.
I think we could load the admin to be checked from the chainlog instead?
- address admin = deps.readAddress(".admin");
+ address admin = chainlog.getAddress("MCD_PAUSE_PROXY");
Contributor
Author
There was a problem hiding this comment.
Ser, in this case it's reading from the output that is exported from the script, which in turn is set to be the PauseProxy: https://github.com/sky-ecosystem/endgame-toolkit/blob/feat/spk-farms-deployment/script/spk-farms/01-UsdsSpkFarmingDeploy.s.sol#L65
0xBasset
requested changes
Sep 25, 2025
| interface VestedRewardsDistributionLike { | ||
| function dssVest() external view returns (address); | ||
|
|
||
| function vestId() external view returns (uint256); |
0xBasset
approved these changes
Oct 14, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add deployment scripts for the new SPK farms.
[sc-2921]