Skip to content

Conversation

@romilbhardwaj
Copy link
Collaborator

Tested (run the relevant ones):

  • Code formatting: install pre-commit (auto-check on commit) or bash format.sh
  • Any manual or new tests for this PR (please specify below)
  • All smoke tests: /smoke-test (CI) or pytest tests/test_smoke.py (local)
  • Relevant individual tests: /smoke-test -k test_name (CI) or pytest tests/test_smoke.py::test_name (local)
  • Backward compatibility: /quicktest-core (CI) or pytest tests/smoke_tests/test_backward_compat.py (local)

@SeungjinYang
Copy link
Collaborator

SeungjinYang commented Nov 16, 2025

We should strive to include an SDK version to all new examples introduced to the repo - I can push to this branch for an SDK version if you'd like.

@SeungjinYang
Copy link
Collaborator

/build-docs

@github-actions
Copy link
Contributor

✅ ReadTheDocs build triggered for branch kimi-k2-thinking

The documentation will be available at: https://docs.skypilot.co/en/kimi-k2-thinking/

@romilbhardwaj
Copy link
Collaborator Author

We should strive to include an SDK version to all new examples introduced to the repo - I can push to this branch for an SDK version if you'd like.

That's a good idea for workload examples (e.g., batch inference on SkyPilot), but this is a model-specific example that's a) less likely to be invoked from python SDK and b) can be easily templatized to have a single SDK example instead for each model(task.from_yaml()?). Maybe that can be a separate PR?

@SeungjinYang
Copy link
Collaborator

Agreed the SDK component shouldn't block the PR merge.

Copy link
Collaborator

@SeungjinYang SeungjinYang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @romilbhardwaj for the example!

@romilbhardwaj romilbhardwaj merged commit 0e434d4 into master Nov 26, 2025
20 checks passed
@romilbhardwaj romilbhardwaj deleted the kimi-k2-thinking branch November 26, 2025 02:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants