-
Notifications
You must be signed in to change notification settings - Fork 857
[Examples] Kimi-K2-Thinking example #7988
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
We should strive to include an SDK version to all new examples introduced to the repo - I can push to this branch for an SDK version if you'd like. |
|
/build-docs |
|
✅ ReadTheDocs build triggered for branch The documentation will be available at: https://docs.skypilot.co/en/kimi-k2-thinking/ |
That's a good idea for workload examples (e.g., batch inference on SkyPilot), but this is a model-specific example that's a) less likely to be invoked from python SDK and b) can be easily templatized to have a single SDK example instead for each model( |
|
Agreed the SDK component shouldn't block the PR merge. |
SeungjinYang
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @romilbhardwaj for the example!
Tested (run the relevant ones):
bash format.sh/smoke-test(CI) orpytest tests/test_smoke.py(local)/smoke-test -k test_name(CI) orpytest tests/test_smoke.py::test_name(local)/quicktest-core(CI) orpytest tests/smoke_tests/test_backward_compat.py(local)