Skip to content

Conversation

@Michaelvll
Copy link
Collaborator

Tested (run the relevant ones):

  • Code formatting: install pre-commit (auto-check on commit) or bash format.sh
  • Any manual or new tests for this PR (please specify below)
  • All smoke tests: /smoke-test (CI) or pytest tests/test_smoke.py (local)
  • Relevant individual tests: /smoke-test -k test_name (CI) or pytest tests/test_smoke.py::test_name (local)
  • Backward compatibility: /quicktest-core (CI) or pytest tests/smoke_tests/test_backward_compat.py (local)

Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR updates file paths and import references to reflect the migration of catalog functionality from sky/clouds/service_catalog to sky/catalog. The changes ensure that packaging configuration and documentation correctly reference the new catalog location.

Key changes:

  • Updated MANIFEST.in to exclude analyze.py from the correct catalog location
  • Updated FAQ documentation to import CATALOG_SCHEMA_VERSION from the correct module

Reviewed Changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File Description
sky/setup_files/MANIFEST.in Updated exclude path for analyze.py from old service_catalog location to new catalog location
docs/source/reference/faq.rst Updated import statement to reference CATALOG_SCHEMA_VERSION from sky.skylet.constants instead of sky.clouds.service_catalog

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@Michaelvll Michaelvll enabled auto-merge (squash) November 20, 2025 22:58
@Michaelvll Michaelvll merged commit 6d46565 into master Dec 2, 2025
26 checks passed
@Michaelvll Michaelvll deleted the catalog-path-fix branch December 2, 2025 07:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants