ignore restart file on the first run #8082
Merged
+24
−82
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
Author
|
/smoke-test --remote-server |
Collaborator
Author
|
/smoke-test |
cblmemo
approved these changes
Nov 25, 2025
Comment on lines
+189
to
+193
| logger.warning( | ||
| f'{colorama.Fore.RED}Consolidation mode for jobs is enabled, ' | ||
| f'but the controller cluster {controller_cn} is still running. ' | ||
| 'Please terminate the controller cluster first.' | ||
| f'{colorama.Style.RESET_ALL}') |
Collaborator
There was a problem hiding this comment.
feeling like we should print out how many running jobs are still on the job controller here - just to get a sense of how many resources are still on the old deployment. same applies for serve.
Collaborator
Author
There was a problem hiding this comment.
It will make this call much slower, so I think it could be a problem.
Collaborator
There was a problem hiding this comment.
Sounds good. Lets just keep this :)
Collaborator
Author
|
smoke test failures are on nightly |
cg505
added a commit
that referenced
this pull request
Nov 25, 2025
* ignore restart file on the first run * avoid crashing the server on inconsistent consolidation mode config * Revert "avoid crashing the server on inconsistent consolidation mode config" This reverts commit dfa985e. * only use a warning for inconsistent consolidation mode
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #8083.
Tested (run the relevant ones):
bash format.sh/smoke-test(CI) orpytest tests/test_smoke.py(local)/smoke-test -k test_name(CI) orpytest tests/test_smoke.py::test_name(local)/quicktest-core(CI) orpytest tests/smoke_tests/test_backward_compat.py(local)