Use binarysearch in Level Compaction and refactor function compact - #147
Open
ppdogg wants to merge 4 commits into
Open
Use binarysearch in Level Compaction and refactor function compact#147ppdogg wants to merge 4 commits into
ppdogg wants to merge 4 commits into
Conversation
Owner
|
The binary-search overlap calculation has blocking edge cases. If the requested key range falls in a gap between two SSTs, lower can be greater than upper, so the inclusive slice panics. If the range lies before the first SST, saturating_sub(1) makes upper equal to zero and incorrectly selects the first SST even though there is no overlap. Please keep the upper bound exclusive, return an empty result when lower is greater than or equal to upper_exclusive, and slice with lower..upper_exclusive. This also needs tests for ranges before the first table, between tables, and after the last table. The unrelated compact refactor would be easier to assess separately. 🤖 (posted by Codex) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Disscussed in issue#136