Skip to content

chore: fix many clippy warnings#166

Merged
skyzh merged 4 commits intoskyzh:mainfrom
Standing-Man:clippy-fix
Mar 15, 2026
Merged

chore: fix many clippy warnings#166
skyzh merged 4 commits intoskyzh:mainfrom
Standing-Man:clippy-fix

Conversation

@Standing-Man
Copy link
Copy Markdown
Contributor

  • fix many clippy warnings
warning: `mini-lsm` (lib test) generated 16 warnings (11 duplicates) (run `cargo clippy --fix --lib -p mini-lsm --tests` to apply 5 suggestions)
warning: hiding a lifetime that's elided elsewhere is confusing
  --> mini-lsm-mvcc/src/tests/harness.rs:76:12
   |
76 |     fn key(&self) -> KeySlice {
   |            ^^^^^     ^^^^^^^^ the same lifetime is hidden here
   |            |
   |            the lifetime is elided here
   |
   = help: the same lifetime is referred to in inconsistent ways, making the signature confusing
help: use `'_` for type paths
   |
76 |     fn key(&self) -> KeySlice<'_> {
   |                              ++++

warning: `mini-lsm-mvcc` (lib test) generated 17 warnings (12 duplicates) (run `cargo clippy --fix --lib -p mini-lsm-mvcc --tests` to apply 5 suggestions)

Signed-off-by: StandingMan <jmtangcs@gmail.com>
Copy link
Copy Markdown
Owner

@skyzh skyzh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks! time to bump my rust compiler..

Signed-off-by: StandingMan <jmtangcs@gmail.com>
Signed-off-by: StandingMan <jmtangcs@gmail.com>
@Standing-Man Standing-Man requested a review from skyzh December 18, 2025 08:10
@Standing-Man Standing-Man force-pushed the clippy-fix branch 2 times, most recently from 0bfc316 to cc80da2 Compare March 15, 2026 00:27
Signed-off-by: StandingMan <jmtangcs@gmail.com>
Copy link
Copy Markdown
Owner

@skyzh skyzh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ty!

@skyzh skyzh merged commit 88543a0 into skyzh:main Mar 15, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants