chore(deps-dev): bump nock from 13.5.6 to 14.0.3 in /packages/web-api #2223
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bumps [nock](https://github.com/nock/nock) from 13.5.6 to 14.0.3. - [Release notes](https://github.com/nock/nock/releases) - [Changelog](https://github.com/nock/nock/blob/main/CHANGELOG.md) - [Commits](nock/nock@v13.5.6...v14.0.3) --- updated-dependencies: - dependency-name: nock dependency-version: 14.0.3 dependency-type: direct:development update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <[email protected]>
dependabot
bot
added
dependencies
❌ 1 Tests Failed:
View the top 1 failed test(s) by shortest run time
To view more test analytics, go to the Test Analytics Dashboard |
| describe('has an option to set request concurrency', () => { | ||
| // TODO: factor out common logic into test helpers | ||
| const responseDelay = 100; // ms | ||
| const responseDelay = 500; // ms |
There was a problem hiding this comment.
On windows I think the delay is too short and the tests assertions are failing, bumping this value seems to make the test stable
There was a problem hiding this comment.
This makes sense to me but I'm open to revisitng this in #2221 👀
mwbrooks
approved these changes
Apr 17, 2025
There was a problem hiding this comment.
✅ Great find @WilliamBergamin! Looks like things are passing, so we can merge. If we start to notice flaky test results, we may want to revert or play with the timeout.
mwbrooks
deleted the
dependabot/npm_and_yarn/packages/web-api/nock-14.0.3
branch
zimeg
reviewed
Apr 17, 2025
| describe('has an option to set request concurrency', () => { | ||
| // TODO: factor out common logic into test helpers | ||
| const responseDelay = 100; // ms | ||
| const responseDelay = 500; // ms |
There was a problem hiding this comment.
This makes sense to me but I'm open to revisitng this in #2221 👀
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bumps nock from 13.5.6 to 14.0.3.
Release notes
Sourced from nock's releases.
... (truncated)
Commits
8348274fix(fetch): cloned response return correct url (#2852)eff7318fix(back): request body unusable in update mode (#2851)ac7a1b2fix(recorder): response body accessed multiple times in parallel requests (#2...6b95833chore(node-version): update node minimum version (#2833)86eff28chore(tests): skip failing test (#2834)ef3f158feat: support for nativefetch(#2813)c8b2b22Fix: GitHub workflow script injection (#2805)Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting
@dependabot rebase.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebasewill rebase this PR@dependabot recreatewill recreate this PR, overwriting any edits that have been made to it@dependabot mergewill merge this PR after your CI passes on it@dependabot squash and mergewill squash and merge this PR after your CI passes on it@dependabot cancel mergewill cancel a previously requested merge and block automerging@dependabot reopenwill reopen this PR if it is closed@dependabot closewill close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually@dependabot show <dependency name> ignore conditionswill show all of the ignore conditions of the specified dependency@dependabot ignore this major versionwill close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this minor versionwill close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this dependencywill close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)