-
Notifications
You must be signed in to change notification settings - Fork 1
The great city revamp #34
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
...but still crash because rooms not found, progress!
# Conflicts: # src/Duets.Cli/Components/Map.fs # src/Duets.Cli/Scenes/Phone/Apps/BnB/Rent.fs # src/Duets.Data/World/Cities/Layouts.fs # src/Duets.Data/World/Ids.fs # src/Duets.Entities/Duets.Entities.fsproj # src/Duets.Entities/Types/World.Types.fs # src/Duets.Simulation/Duets.Simulation.fsproj # src/Duets.Simulation/WorldNavigation/Navigation.fs
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This chunky boy of a PR finally addresses one of my main pain points with the game: cities were boring! My initial idea was to do the huge work of adding descriptors to each street and then, through many many many layers of matches, create sort of personalized descriptions for each street in a city. This proved not to work quite as much as I imagined, so I turned to attempt using a local LLM to do the work for each description.
There's still a bunch of work to do with this, but as a first draft I think it works pretty well. Major points of the PR are:
lookcommand, but I'm planning to expand the usage around the game for dialogues and other descriptions like concert results.