Drop setAccessible() usage for PHP 8.5 support#3404
Closed
arshidkv12 wants to merge 2 commits intoslimphp:4.xfrom
Closed
Drop setAccessible() usage for PHP 8.5 support#3404arshidkv12 wants to merge 2 commits intoslimphp:4.xfrom
arshidkv12 wants to merge 2 commits intoslimphp:4.xfrom
Conversation
flangofas
approved these changes
Aug 22, 2025
Contributor
|
There is a lot of redundant code. Could you move this into a method? |
Author
|
ok. |
Member
|
If we drop support for anything less than PHP 8.1, we could just delete the calls to setAccessible(). Unfortunately, 8.1 was only release 4 years ago, which might be a little too recent. What do you think @odan ? |
Contributor
|
@akrabat I think keeping PHP 8.1 adds extra maintenance overhead (CI jobs, tests, etc.). I would suggest aligning with PHP’s official security timeline and keeping 8.1 support only until 31 Dec 2025 (supported versions). |
Contributor
|
Thanks for the PR. We are working on the changes for PHP 8.5 in this PR: #3415 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Remove
setAccessible()calls to support PHP 8.5 and avoid deprecation