Skip to content

C++: fix crash when accessing deleted parent #9863

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Oct 28, 2025
Merged

C++: fix crash when accessing deleted parent #9863

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
3ad276b
C++: Fix crash when accessing C++ parent
ogoffart Oct 27, 2025
403c1b3
C++: Fix close popup from deleted parents
ogoffart Oct 27, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
37 changes: 37 additions & 0 deletions api/cpp/include/slint_window.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,43 @@ namespace private_api {
using ItemTreeRc = vtable::VRc<cbindgen_private::ItemTreeVTable>;
using slint::LogicalPosition;

/// Looking forward for C++23 std::optional::transform
template<typename T, typename F>
auto optional_transform(const std::optional<T> &o, F &&f) -> decltype(std::optional(f(*o)))
{
if (o) {
return std::optional(f(*o));
}
return std::nullopt;
}

template<typename T, typename F>
void optional_then(const std::optional<T> &o, F &&f)
{
if (o) {
f(*o);
}
}

/// Waiting for C++23 std::optional::and_then
template<typename T, typename F>
auto optional_and_then(const std::optional<T> &o, F &&f) -> decltype(f(*o))
{
if (o) {
return f(*o);
}
return std::nullopt;
}

template<typename T>
T optional_or_default(const std::optional<T> &o)
{
if (o) {
return *o;
}
return {};
}

class WindowAdapterRc
{
public:
Expand Down
Loading
Loading