Skip to content

Conversation

@ogoffart
Copy link
Member

Regressed in 768c895

Fixes #9860

@ogoffart
Copy link
Member Author

Note that I have no idea what i'm doing, I just found a function that could be converted to the right type in the canvas and my second attempt seems to work

Copy link
Member

@tronical tronical left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Odd that this is now needed, but makes sense also to provide the Ganesh context. Could you check if this also works when using skia's software renderer (without recording context)?

@ogoffart
Copy link
Member Author

Odd that this is now needed

Some kind of context was required before the update as well. The update removed it.
(Note that the "colorized" image have also effect applied to them so it make sense that this is a texture)

Could you check if this also works when using skia's software renderer

I confirm that winit-skia-software was not broken on my system and that this patch has no effect with it

@ogoffart ogoffart added the candidate-for-bugfix-release Label for PRs that would make sense to cherry-pick into a spontaneously created bug fix release bran label Oct 28, 2025
@tronical
Copy link
Member

Great :)

@ogoffart ogoffart merged commit b9bdd01 into master Oct 28, 2025
41 checks passed
@ogoffart ogoffart deleted the olivier/fix-#9860 branch October 28, 2025 09:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

candidate-for-bugfix-release Label for PRs that would make sense to cherry-pick into a spontaneously created bug fix release bran

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Colorize on tiled svg no longer works

3 participants