fix the build pipeline failure#7
Merged
slowcoder360 merged 2 commits intoslowcoder360:masterfrom Mar 11, 2026
Merged
Conversation
test-data may contain unsafe code and vibesafe detects it as unsafe. This makes the build pipeline fails because one of the step is to check if vibesafe itself is unsafe and in this check we shouldnt consider the test-data directory
Owner
|
Thank you for your help! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixed #5
Problem
The build pipeline after PR merge fails because vibesafe scan itself to find if it has some security issues and it finds them in the
test-datadirectory, because we have there some tests with unsafe code that vibesafe correctly find.The Solution
Adding
test-datato the.vibesafeignorefileAlso a formatting error in the README.md was remove