Skip to content

make max candidates default for us-street-api be 1 - the same as the api itself. #122

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
JacobMcKenzieSmarty wants to merge 1 commit into
base: master
Choose a base branch
from
Open

make max candidates default for us-street-api be 1 - the same as the api itself. #122

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/us_street/Client.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,7 @@ class Client {

if (dataIsLookup) {
if (data.maxCandidates == null && data.match == "enhanced")
data.maxCandidates = 5;
data.maxCandidates = 1;
batch = new Batch();
batch.add(data);
} else {
Expand Down
4 changes: 2 additions & 2 deletions tests/us_street/test_Client.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,14 +49,14 @@ describe("A US Street client", function () {
expect(mockSender.request.parameters).to.deep.equal(expectedParameters);
});

it("defaults maxCandidates to 5 when match type is enhanced.", function () {
it("defaults maxCandidates to 1 when match type is enhanced.", function () {
let mockSender = new MockSender();
const client = new Client(mockSender);
let lookup = new Lookup();
lookup.match = "enhanced";
let expectedParameters = {
match: "enhanced",
candidates: 5,
candidates: 1,
};

client.send(lookup);
Expand Down