Add document discrinator sanitizer for JSON protocols #932
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mtdowling
requested changes
Nov 14, 2025
...nt-awsjson/src/main/java/software/amazon/smithy/java/aws/client/awsjson/AwsJsonProtocol.java
Show resolved
Hide resolved
| */ | ||
| public AwsJson1Protocol(ShapeId service) { | ||
| super(TRAIT_ID, service); | ||
| super(TRAIT_ID, service, ErrorTypeSanitizer::REMOVE_URI); |
Member
There was a problem hiding this comment.
I think both of these protocols would need to remove namespace and URI. IIRC, an error can have a full namespace in the response even if using aws json 1.0.
Contributor
Author
There was a problem hiding this comment.
From our doc, the 1.0 will use full shapeid for type. Does that indicate we should preserve the namespace?
codecs/json-codec/src/main/java/software/amazon/smithy/java/json/JsonSettings.java
Outdated
Show resolved
Hide resolved
codecs/json-codec/src/main/java/software/amazon/smithy/java/json/ErrorTypeSanitizer.java
Show resolved
Hide resolved
sugmanue
reviewed
Nov 14, 2025
codecs/json-codec/src/main/java/software/amazon/smithy/java/json/ErrorTypeSanitizer.java
Outdated
Show resolved
Hide resolved
codecs/json-codec/src/main/java/software/amazon/smithy/java/json/ErrorTypeSanitizer.java
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR includes multiple changes:
__typeas the error's shapeId and different JSON protocols have different requirement for__type's format.With this fix, those protocol tests with
__typerequirement can pass.By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.