Initial setup for credential resolution feature tracking #4224

landonxjames · 2025-07-18T03:20:04Z

Motivation and Context

Initial setup for tracking credential/identity resolution based features.

Description

The biggest change here is the addition of a new aws-features crate containing the sdk_features module that used to live in aws-runtime. This was done so that the AwsSdkFeature type could be referenced in the aws-credential-types crate without causing a circular dependency.

Initially I was just going to pass along the types without downcasting, but they would have had to be downcast eventually, since in the Credentials typemap they are Vec<AwsSdkFeature> but to add them to a Layer we need to extract the individual AwsSdkFeatures from the Vec. This could either happen in aws-credential-types where From<Credentials> for Identity is implemented or in aws-smithy-runtime in the orchestrator where the Identity is resolved. Since these credentials types are AWS specific it seemed to make more sense to keep it in aws/rust-runtime.

Other changes:

Add a typemap to Credentials (and manually implement the previously derived traits for it) to carry the feature information
Update the From<Credentials> for Identity implementation to extract the AwsSdkFeatures and pass them in a Layer to the Identity's typemap.
Update resolve_identity in the orchestrator to extract the FrozenLayer from Identity and insert it in the ConfigBag so that the UserAgentInterceptor can extract it later.

Testing

Added new tests around Credentials equality and the updated From<Credentials> for Identity implementation.

Note on failing semver test: Failing because the UnwindSafe traits are no longer auto implemented for Credentials

--- failure auto_trait_impl_removed: auto trait no longer implemented ---

Description:
A public type has stopped implementing one or more auto traits. This can break downstream code that depends on the traits being implemented.
        ref: https://doc.rust-lang.org/reference/special-types-and-traits.html#auto-traits
       impl: https://github.com/obi1kenobi/cargo-semver-checks/tree/v0.41.0/src/lints/auto_trait_impl_removed.ron

Failed in:
  type Credentials is no longer UnwindSafe, in /home/build/workspace/smithy-rs/aws-sdk/sdk/aws-credential-types/src/credentials_impl.rs:29
  type Credentials is no longer RefUnwindSafe, in /home/build/workspace/smithy-rs/aws-sdk/sdk/aws-credential-types/src/credentials_impl.rs:29Cloning base

This is due to us adding a HashMap<TypeId, TypeErasedBox> to Credentials. We could likely wrap this in an Arc<Mutex<>> to keep it mutable and get back the unwind safety, but that doesn't feel like it justifies the added complexity. Open to debate on this one though.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

github-actions · 2025-07-18T19:01:38Z

A new generated diff is ready to view.

AWS SDK (ignoring whitespace)
Client Test (ignoring whitespace)
No codegen difference in the Server Test
No codegen difference in the Server Test Python
No codegen difference in the Server Test Typescript

A new doc preview is ready to view.

github-actions · 2025-07-18T20:18:08Z

A new generated diff is ready to view.

AWS SDK (ignoring whitespace)
Client Test (ignoring whitespace)
No codegen difference in the Server Test
No codegen difference in the Server Test Python
No codegen difference in the Server Test Typescript

A new doc preview is ready to view.

ysaito1001

Yeah, looks clearer to hoist AWS SDK features to a upstream crate altogether, as opposed to special casing credentials-related features with AwsSdkCredentialsFeatures defined in aws-credential-types.

Great start!

aws/rust-runtime/aws-credential-types/src/credentials_impl.rs

github-actions · 2025-07-21T15:23:03Z

A new generated diff is ready to view.

AWS SDK (ignoring whitespace)
Client Test (ignoring whitespace)
No codegen difference in the Server Test
No codegen difference in the Server Test Python
No codegen difference in the Server Test Typescript

A new doc preview is ready to view.

github-actions · 2025-07-21T15:59:30Z

A new generated diff is ready to view.

AWS SDK (ignoring whitespace)
Client Test (ignoring whitespace)
No codegen difference in the Server Test
No codegen difference in the Server Test Python
No codegen difference in the Server Test Typescript

A new doc preview is ready to view.

aajtodd · 2025-07-21T16:49:33Z

aws/rust-runtime/aws-credential-types/src/credentials_impl.rs

        builder.set_expiration(expiry);
-        builder.build().expect("set required fields")
+
+        if let Some(features) = val.get_property::<Vec<AwsSdkFeature>>().cloned() {


Seems like it doesn't matter where this lives if aws-credential-types has to know about it. Alternatively could just make a new AwsCredentialFeature enum inside aws-credential-types and implement BusinessMetric conversions for that in aws-runtime. Would mean we don't need a new crate for this.

Hmm, after thinking about the point of having a repository-like crate, I've started learning towards this idea of defining AwsCredentialFeature in aws-credential-types...

Sounds like we are leaning towards a separate enum. I still prefer only having two feature enums (AWS and Smithy) since it seems cleaner, but don't know that that preference is strong enough to justify a new crate. Will make the change today.

Switched to an AwsCredentialFeature enum and removed the aws-features crate in 6bcea29

aajtodd

Looks good, brought up one possible suggestion to avoid a new crate but otherwise looks fine.

github-actions · 2025-07-21T16:58:40Z

A new generated diff is ready to view.

AWS SDK (ignoring whitespace)
Client Test (ignoring whitespace)
No codegen difference in the Server Test
No codegen difference in the Server Test Python
No codegen difference in the Server Test Typescript

A new doc preview is ready to view.

ysaito1001 · 2025-07-23T15:58:52Z

rust-runtime/aws-smithy-runtime/src/client/orchestrator/auth.rs

+                        // Extract the FrozenLayer placed in the Identity property bag by the From<Credentials> impl.
+                        // This layer contains AwsSdkFeatures for the user agent


+1 for adding comments, but since this is in generic smithy runtime and Identity's frozen layer could be used for something else, so either I'd remove the comments or make them more abstract, so they're not tied specifically to AwsSdkFeatures.

Good call, made comment more generic in b785a6e

github-actions · 2025-07-23T18:37:47Z

A new generated diff is ready to view.

AWS SDK (ignoring whitespace)
Client Test (ignoring whitespace)
No codegen difference in the Server Test
No codegen difference in the Server Test Python
No codegen difference in the Server Test Typescript

A new doc preview is ready to view.

github-actions · 2025-07-23T19:52:07Z

A new generated diff is ready to view.

AWS SDK (ignoring whitespace)
Client Test (ignoring whitespace)
No codegen difference in the Server Test
No codegen difference in the Server Test Python
No codegen difference in the Server Test Typescript

A new doc preview is ready to view.

github-actions · 2025-07-23T20:52:12Z

A new generated diff is ready to view.

AWS SDK (ignoring whitespace)
Client Test (ignoring whitespace)
No codegen difference in the Server Test
Server Test Python (ignoring whitespace)
No codegen difference in the Server Test Typescript

A new doc preview is ready to view.

## Motivation and Context   Continuing the work in #4224, adding user-agent feature tracking for Credential Providers. ## Description  Added `AwsCredentialFeatures` properties for each implementor of `ProvideCredentials` in `aws-config`. ## Testing    Added integration tests for each of the supported Credential Providers. This required exposing some previously `pub(crate)` utility functions as `pub` under a `test-util` feature flag. ---- _By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice._

## Motivation and Context   Merging the feature branch containing work from the below two PRs: * #4238 * #4224 ## Checklist  - [x] For changes to the AWS SDK, generated SDK code, or SDK runtime crates, I have created a changelog entry Markdown file in the `.changelog` directory, specifying "aws-sdk-rust" in the `applies_to` key. ---- _By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice._ --------- Co-authored-by: AWS SDK Rust Bot <[email protected]>

landonxjames added 5 commits July 15, 2025 16:05

Initial setup for credentials feature ids

6915531

Finish setup for credential feature id tracking

2e42100

Merge branch 'main' into landonxjames/credentials-feature-id

f55c876

Fixup lockfile

92f4c14

Add aws-features to crateSet

372f510

Fix broken metrics tests

3d0cec2

landonxjames marked this pull request as ready for review July 18, 2025 21:02

landonxjames requested review from a team as code owners July 18, 2025 21:02

ysaito1001 approved these changes Jul 18, 2025

View reviewed changes

aws/rust-runtime/aws-credential-types/src/credentials_impl.rs Outdated Show resolved Hide resolved

aws/rust-runtime/aws-credential-types/src/credentials_impl.rs Outdated Show resolved Hide resolved

PR comments

ddcbeca

Tags tests with cfg(test-util)

1ddb372

Feature gate test deps

97b964e

aajtodd reviewed Jul 21, 2025

View reviewed changes

aajtodd approved these changes Jul 21, 2025

View reviewed changes

ysaito1001 reviewed Jul 23, 2025

View reviewed changes

Update comment about extracting layer from Identity in Orchestrator

b785a6e

Remove aws-features crate in favor of an enum in aws-credential-types

6bcea29

Update crate versions

b9c5732

landonxjames merged commit 3965ea8 into feature/credential-features Jul 24, 2025
44 of 45 checks passed

landonxjames deleted the landonxjames/credentials-feature-id branch July 24, 2025 15:57

landonxjames mentioned this pull request Jul 28, 2025

Add AwsCredentialFeatures to Credential Providers #4238

Merged

landonxjames mentioned this pull request Jul 30, 2025

Merge feature/credential-features branch to main #4240

Merged

1 task

		// Extract the FrozenLayer placed in the Identity property bag by the From<Credentials> impl.
		// This layer contains AwsSdkFeatures for the user agent

Initial setup for credential resolution feature tracking #4224

Initial setup for credential resolution feature tracking #4224

Uh oh!

Conversation

landonxjames commented Jul 18, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Motivation and Context

Description

Testing

Uh oh!

github-actions bot commented Jul 18, 2025

Uh oh!

github-actions bot commented Jul 18, 2025

Uh oh!

ysaito1001 left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

github-actions bot commented Jul 21, 2025

Uh oh!

github-actions bot commented Jul 21, 2025

Uh oh!

aajtodd Jul 21, 2025

Choose a reason for hiding this comment

Uh oh!

ysaito1001 Jul 23, 2025

Choose a reason for hiding this comment

Uh oh!

landonxjames Jul 23, 2025

Choose a reason for hiding this comment

Uh oh!

landonxjames Jul 23, 2025

Choose a reason for hiding this comment

Uh oh!

aajtodd left a comment

Choose a reason for hiding this comment

Uh oh!

github-actions bot commented Jul 21, 2025

Uh oh!

ysaito1001 Jul 23, 2025

Choose a reason for hiding this comment

Uh oh!

landonxjames Jul 23, 2025

Choose a reason for hiding this comment

Uh oh!

github-actions bot commented Jul 23, 2025

Uh oh!

github-actions bot commented Jul 23, 2025

Uh oh!

github-actions bot commented Jul 23, 2025

Uh oh!

Uh oh!

Uh oh!

landonxjames commented Jul 18, 2025 •

edited

Loading