Skip to content

Conversation

ysaito1001
Copy link
Contributor

@ysaito1001 ysaito1001 commented Jul 24, 2025

Motivation and Context

Implements fallback equality for no auth AuthSchemeId so that AuthSchemeId::from("no_auth") (legacy) and AuthSchemeId::from("noAuth") (updated) should be treated as equivalent.

Description

In #4203, the internal raw strings of pre-defined AuthSchemeId were updated to better align with the Smithy spec (discussion). Acknowledging that this was a breaking change and that customers should not rely on these internal representations, we did receive reports of issues related to this update. After discussion, we proceeded with implementing fallback equality for no auth scheme ID to allow for a safer rollout.

Testing

  • Added unit tests for manually implemented traits for AuthSchemeId, PartialEq, Hash, and Ord (became unnecessary after 7922ef9)
  • Added an auth scheme preference test to verify the legacy no_auth is supported

Checklist

  • For changes to the smithy-rs codegen or runtime crates, I have created a changelog entry Markdown file in the .changelog directory, specifying "client," "server," or both in the applies_to key.
  • For changes to the AWS SDK, generated SDK code, or SDK runtime crates, I have created a changelog entry Markdown file in the .changelog directory, specifying "aws-sdk-rust" in the applies_to key.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Copy link

A new generated diff is ready to view.

A new doc preview is ready to view.

@ysaito1001 ysaito1001 marked this pull request as ready for review July 24, 2025 21:01
@ysaito1001 ysaito1001 requested review from a team as code owners July 24, 2025 21:01
Copy link
Contributor

@landonxjames landonxjames left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One potential suggestion for a log, but no blockers

@ysaito1001 ysaito1001 requested review from rcoh and jlizen July 24, 2025 23:05
@ysaito1001 ysaito1001 enabled auto-merge (squash) July 24, 2025 23:10
Copy link

A new generated diff is ready to view.

A new doc preview is ready to view.

@ysaito1001 ysaito1001 merged commit a2a7d7a into main Jul 24, 2025
45 checks passed
@ysaito1001 ysaito1001 deleted the ysaito/fallback-equality-for-no-auth-scheme-id branch July 24, 2025 23:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants