Add fallback equality on noAuth
scheme ID
#4232
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation and Context
Implements fallback equality for no auth
AuthSchemeId
so thatAuthSchemeId::from("no_auth")
(legacy) andAuthSchemeId::from("noAuth")
(updated) should be treated as equivalent.Description
In #4203, the internal raw strings of pre-defined
AuthSchemeId
were updated to better align with the Smithy spec (discussion). Acknowledging that this was a breaking change and that customers should not rely on these internal representations, we did receive reports of issues related to this update. After discussion, we proceeded with implementing fallback equality for no auth scheme ID to allow for a safer rollout.Testing
Added unit tests for manually implemented traits for(became unnecessary after 7922ef9)AuthSchemeId
,PartialEq
,Hash
, andOrd
no_auth
is supportedChecklist
.changelog
directory, specifying "client," "server," or both in theapplies_to
key..changelog
directory, specifying "aws-sdk-rust" in theapplies_to
key.By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.