Skip to content

fix(core): increase priority of types conditional exports #1650

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 16, 2025

Conversation

kuhe
Copy link
Contributor

@kuhe kuhe commented Jul 16, 2025

This changes the ordering of the conditional exports to match the AWS SDK core, which was done in aws/aws-sdk-js-v3#6967.

This should fix one of the issues raised in:
https://arethetypeswrong.github.io/?p=%40smithy%2Fcore%403.6.0
and may help with aws/aws-sdk-js-v3#7188

@kuhe kuhe requested a review from a team as a code owner July 16, 2025 15:46
@kuhe kuhe merged commit 312801c into smithy-lang:main Jul 16, 2025
11 checks passed
@kuhe kuhe deleted the fix/types branch July 16, 2025 16:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants