Skip to content

Removing appliesTo from NullAndEmptyHeaders tests #2438

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Removing appliesTo from NullAndEmptyHeaders tests #2438

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 2 additions & 4 deletions smithy-aws-protocol-tests/model/restJson1/http-headers.smithy
View file
Open in desktop
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since these two operations and their tests (NullAndEmptyHeaders(Client/Server)) are now identical, can we just combine them into one and get rid of the client-only/server-only tags? For restXml too

Original file line number Diff line number Diff line change
Expand Up @@ -432,14 +432,13 @@ apply NullAndEmptyHeadersClient @httpRequestTests([
headers: {
"X-B": ""
"X-C": ""
}
},
body: "",
params: {
a: null,
b: "",
c: [],
},
appliesTo: "client",
},
])

Expand All @@ -462,13 +461,12 @@ apply NullAndEmptyHeadersServer @httpResponseTests([
headers: {
"X-B": ""
"X-C": ""
}
},
params: {
a: null,
b: "",
c: [],
},
appliesTo: "server",
},
])

Expand Down
6 changes: 2 additions & 4 deletions smithy-aws-protocol-tests/model/restXml/http-headers.smithy
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -375,14 +375,13 @@ apply NullAndEmptyHeadersClient @httpRequestTests([
headers: {
"X-B": ""
"X-C": ""
}
},
body: "",
params: {
a: null,
b: "",
c: [],
},
appliesTo: "client",
},
])

Expand All @@ -405,14 +404,13 @@ apply NullAndEmptyHeadersServer @httpResponseTests([
headers: {
"X-B": ""
"X-C": ""
}
},
body: "",
params: {
a: null,
b: "",
c: [],
},
appliesTo: "server",
},
])

Expand Down
Loading