Update query params output test in rest-json #2739
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Background
This change updates the RestJsonIgnoreQueryParamsInResponse test to enforce deserializing a body element that is also bound as a query parameter.
This test has a rest-xml equivalent that follows this same pattern.
Additionally, the extra test about "no payload" does not seem to make sense anymore in this context and has been deleted - the description of the test above says that server implementations have been updated to always return an empty json. Additionally, an empty string would never be returned in this case because there will be a payload that needs to be deserialized.
Testing
Smithy Ruby
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.